fix example not compatible with server skeleton#126
Open
k2s wants to merge 3 commits intoSocketCluster:masterfrom
Open
fix example not compatible with server skeleton#126k2s wants to merge 3 commits intoSocketCluster:masterfrom
k2s wants to merge 3 commits intoSocketCluster:masterfrom
Conversation
socketcluster create generates example of `random` event and not `rand`
jondubois
force-pushed
the
master
branch
2 times, most recently
from
9d2473c to
4830adc
Compare
Member
|
This PR makes a number of different changes. Would have been better as separate PRs. The changes related to base64 would need to be checked carefully as we want to have maximum portability (browser envs, server env, ...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socketcluster create generates example of
randomevent and notrand